[Dataset Quality] Added Dataset Quality Locator #177000

mohamedhamed-ahmed · 2024-02-15T10:31:46Z

📝 Summary

This PR adds the infrastructure work for the locators needed to create the navigation link from the Logs Explorer to the Dataset Quality Page, but the links themselves are to be added with a later ticket.

💡For Reviewers

To be abled to test this PR you can add the below code here to make the link visible in the Logs Explorer Page.

<ConnectedDatasetQualityLink /> <VerticalRule />

🎥 Demo

datasetqualitynavigation.mov

apmmachine · 2024-02-15T10:32:01Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mohamedhamed-ahmed · 2024-02-20T11:45:22Z

packages/deeplinks/observability/locators/dataset_quality.ts

the types here will be removed as part of another ticket to make use of the types from the data plugin
https://github.com/elastic/kibana/blob/9e04d2c5c7b2139b7e23743b133ea79bf93f5ba3/src/plugins/data/common/query/timefilter/types.ts

mohamedhamed-ahmed · 2024-02-20T11:45:53Z

...aset_quality/public/components/dataset_quality/summary_panel/datasets_quality_indicators.tsx

  const qualityCounts = mapPercentagesToQualityCounts(datasetsQuality.percentages);
+  const datasetsWithoutIgnoredField =


not part of the PR scope but a bug that is found and decided to fix it here

mohamedhamed-ahmed · 2024-02-20T11:46:58Z

.../observability_logs_explorer/common/locators/utils/construct_dataset_quality_locator_path.ts

this file will later on be moved to the dataset quality plugin as we are planning to create our own app

mohamedhamed-ahmed · 2024-02-20T11:47:31Z

...bservability_solution/observability_logs_explorer/public/components/dataset_quality_link.tsx

+): DatasetQualityLocatorParams => {
+  const { time, refreshInterval } = logsExplorerState;
+  const locatorParams: DatasetQualityLocatorParams = {
+    filters: {


this construction will be refactored when we use the types from the data plugin

yngrdyn · 2024-02-21T11:51:07Z

x-pack/plugins/observability_solution/observability_logs_explorer/public/plugin.ts

@@ -95,6 +96,10 @@ export class ObservabilityLogsExplorerPlugin
        useHash,
      })
    );
+    const datasetQualityLocator = share.url.locators.create(
+      new DatasetQualityLocatorDefinition({})


Why are we not using useHash here? What's the difference?

yes correct will add it here we should read it from state:storeInSessionStorage

yngrdyn · 2024-02-21T13:56:14Z

.../observability_logs_explorer/common/locators/utils/construct_dataset_quality_locator_path.ts

+  const pageState = datasetQualityUrlSchemaV1.urlSchemaRT.encode(
+    deepCompactObject({
+      v: 1,
+      filters,


Here we will be not only taking into account timeRange or the other filters as well?

at the moment I am only passing the timerange, its the only filter added to the locator params.
We can later add more filters to the interface

x-pack/plugins/dataset_quality/public/hooks/use_summary_panel.tsx

yngrdyn

LGTM 🚀

kibana-ci · 2024-02-22T11:01:18Z

💚 Build Succeeded

Buildkite Build
Commit: 8e3ed81

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1620	1621	+1
`datasetQuality`	167	168	+1
`discover`	724	725	+1
`logsExplorer`	676	677	+1
`logsShared`	223	224	+1
`observability`	599	600	+1
`observabilityLogsExplorer`	203	206	+3
`observabilityOnboarding`	196	197	+1
total			+10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/deeplinks-observability`	26	29	+3
`observabilityLogsExplorer`	20	21	+1
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`datasetQuality`	136.3KB	136.4KB	+104.0B
`observabilityLogsExplorer`	149.5KB	149.5KB	+3.0B
total			+107.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityLogsExplorer`	13.5KB	14.3KB	+814.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/deeplinks-observability`	37	40	+3
`observabilityLogsExplorer`	20	21	+1
total			+4

ESLint disabled line counts

id	before	after	diff
`@kbn/deeplinks-observability`	5	8	+3

Total ESLint disabled count

id	before	after	diff
`@kbn/deeplinks-observability`	5	8	+3

History

💛 Build #194607 was flaky e5467a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This is a [follow up](#177000 (comment)) PR of #177000. ## Changes - Replace custom types for `timeRangeConfig` in dataset quality with common types coming from data plugin.

This is a [follow up](elastic#177000 (comment)) PR of elastic#177000. ## Changes - Replace custom types for `timeRangeConfig` in dataset quality with common types coming from data plugin.

closes elastic#170611 ## 📝 Summary This PR adds the infrastructure work for the locators needed to create the navigation link from the Logs Explorer to the Dataset Quality Page, but the links themselves are to be added with a later ticket. ## 💡For Reviewers To be abled to test this PR you can add the below code [here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx#L150) to make the link visible in the Logs Explorer Page. `<ConnectedDatasetQualityLink /> <VerticalRule />` ## 🎥 Demo https://github.com/elastic/kibana/assets/11225826/1f3ce10a-3b8c-4027-b72d-1ed71b782fa5

This is a [follow up](elastic#177000 (comment)) PR of elastic#177000. ## Changes - Replace custom types for `timeRangeConfig` in dataset quality with common types coming from data plugin.

elasticmachine · 2024-03-21T09:46:01Z

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

[Dataset Quality] Added link from Logs Explorer to Dataset Quality

8e5d847

mohamedhamed-ahmed added 3 commits February 20, 2024 10:30

Resolve Merge Conflicts

24ef352

Add TimeRange Filter Locator Params

ac505ed

Remove unused references

7d6f5c8

mohamedhamed-ahmed commented Feb 20, 2024

View reviewed changes

mohamedhamed-ahmed marked this pull request as ready for review February 20, 2024 11:49

mohamedhamed-ahmed requested a review from a team as a code owner February 20, 2024 11:49

mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.14.0 labels Feb 20, 2024

Merge branch 'main' into 170611-logs-explorer-link-to-dataset-quality

e5467a4

yngrdyn reviewed Feb 21, 2024

View reviewed changes

mohamedhamed-ahmed changed the title ~~[Dataset Quality] Added link from Logs Explorer to Dataset Quality~~ [Dataset Quality] Added Dataset Quality Locators Feb 21, 2024

mohamedhamed-ahmed changed the title ~~[Dataset Quality] Added Dataset Quality Locators~~ [Dataset Quality] Added Dataset Quality Locator Feb 21, 2024

yngrdyn reviewed Feb 21, 2024

View reviewed changes

x-pack/plugins/dataset_quality/public/hooks/use_summary_panel.tsx Show resolved Hide resolved

Added useHash to locator deps

7e6190e

yngrdyn approved these changes Feb 22, 2024

View reviewed changes

Merge branch 'main' into 170611-logs-explorer-link-to-dataset-quality

8e3ed81

yngrdyn merged commit 9a47387 into elastic:main Feb 22, 2024
16 checks passed

yngrdyn mentioned this pull request Feb 22, 2024

[Dataset quality] using common data types for timeRange #177630

Merged

yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dataset Quality] Added Dataset Quality Locator #177000

[Dataset Quality] Added Dataset Quality Locator #177000

mohamedhamed-ahmed commented Feb 15, 2024 •

edited

Loading

apmmachine commented Feb 15, 2024

mohamedhamed-ahmed Feb 20, 2024

mohamedhamed-ahmed Feb 20, 2024

mohamedhamed-ahmed Feb 20, 2024

mohamedhamed-ahmed Feb 20, 2024

yngrdyn Feb 21, 2024 •

edited

Loading

mohamedhamed-ahmed Feb 22, 2024

yngrdyn Feb 21, 2024 •

edited

Loading

mohamedhamed-ahmed Feb 22, 2024

yngrdyn left a comment

kibana-ci commented Feb 22, 2024

API count

ESLint disabled line counts

Total ESLint disabled count

elasticmachine commented Mar 21, 2024

		const qualityCounts = mapPercentagesToQualityCounts(datasetsQuality.percentages);
		const datasetsWithoutIgnoredField =

[Dataset Quality] Added Dataset Quality Locator #177000

[Dataset Quality] Added Dataset Quality Locator #177000

Conversation

mohamedhamed-ahmed commented Feb 15, 2024 • edited Loading

📝 Summary

💡For Reviewers

🎥 Demo

apmmachine commented Feb 15, 2024

🤖 GitHub comments

mohamedhamed-ahmed Feb 20, 2024

Choose a reason for hiding this comment

mohamedhamed-ahmed Feb 20, 2024

Choose a reason for hiding this comment

mohamedhamed-ahmed Feb 20, 2024

Choose a reason for hiding this comment

mohamedhamed-ahmed Feb 20, 2024

Choose a reason for hiding this comment

yngrdyn Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

mohamedhamed-ahmed Feb 22, 2024

Choose a reason for hiding this comment

yngrdyn Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

mohamedhamed-ahmed Feb 22, 2024

Choose a reason for hiding this comment

yngrdyn left a comment

Choose a reason for hiding this comment

kibana-ci commented Feb 22, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

elasticmachine commented Mar 21, 2024

mohamedhamed-ahmed commented Feb 15, 2024 •

edited

Loading

yngrdyn Feb 21, 2024 •

edited

Loading

yngrdyn Feb 21, 2024 •

edited

Loading